On Fri, Oct 19, 2007 at 02:35:35PM +0200, Hannes Reinecke wrote:
> Christoph Hellwig wrote:
> > I think this needs a little restructuring. ahd_pci_suspend/ahd_pci_resume
> > should be merged into their callers and use the normal Linux pci accessors,
> > and ahd_suspend/ahd_resume are tiny enough to merged into the caller aswell.
> > 
> Yes, partially. ahc_pci_resume() has to stay there as it uses quite some
> functions from aic7xxx_pci.c. And I'd rather keep the overall structure
> (ie split between linux-specific and generic pci access) for now.
> In the long run it should be restructured as we don't do cross-compilation
> with ***BSD anymore.

Ok..

> Ok. Done.
> Updated patch attached.
> More to your liking?

Much better.  There's still some if ((rc = fo())) left, but it's probably
not worth to delay the patch further because of that.  Just clean it up
in a followon patch.

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to