FUJITA Tomonori wrote:
If cdev_add fails in sg_add, sg_remove crashes since class_data is bogus.Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/sg.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index f1871ea..92b4367 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -1418,7 +1418,6 @@ sg_add(struct class_device *cl_dev, struct class_interface *cl_intf) goto out; }- class_set_devdata(cl_dev, sdp);error = cdev_add(cdev, MKDEV(SCSI_GENERIC_MAJOR, sdp->index), 1); if (error) goto cdev_add_err; @@ -1447,6 +1446,8 @@ sg_add(struct class_device *cl_dev, struct class_interface *cl_intf) "Attached scsi generic sg%d type %d\n", sdp->index, scsidp->type);+ class_set_devdata(cl_dev, sdp);+ return 0;cdev_add_err:
Tomo, Thanks. Signed-off-by: Douglas Gilbert <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
