--- On Wed, 2/6/08, Salyzyn, Mark <[EMAIL PROTECTED]> wrote:
> From: Salyzyn, Mark <[EMAIL PROTECTED]>
> Subject: [PATCH 1/1] aacraid: do not set valid bit in sense information
> To: "[email protected]" <[email protected]>
> Cc: "Tony Battersby" <[EMAIL PROTECTED]>, "[EMAIL PROTECTED]" <[EMAIL
> PROTECTED]>, "Mike Snitzer" <[EMAIL PROTECTED]>
> Date: Wednesday, February 6, 2008, 1:54 PM
> Luben Tuikov [mailto:[EMAIL PROTECTED] sez:
> > Just as in your case and Tony's case, which I
> presume
> > uses the same RAID firmware vendor, it would've
> > probably been better if the RAID firmware vendor
> > fixed the firmware to not set the VALID bit if the
> > INFORMATION field is not valid.
>
> Point taken regarding the aacraid driver. Dropped the VALID
> bit, and then did some cleanup/simplification of the
> set_sense procedure and the associated parameters. Mike did
> some preliminary tests when the VALID bit was dropped before
> the 'Re: [PATCH] [SCSI] sd: make error handling more
> robust' patches came on the scene. The change in the
> SCSI subsystem does make this enclosed aacraid patch
> unnecessary, so this aacraid patch is merely post battle
> ground cleanup. If the simplification is an issue,
> repugnant, too much for a back-port to the stable trees or
> clouds the point, this patch could be happily distilled
> down to:
Sounds good.
Luben
>
> diff -ru a/drivers/scsi/aacraid/aachba.c
> b/drivers/scsi/aacraid/aachba.c
> --- a/drivers/scsi/aacraid/aachba.c 2008-02-06
> 16:26:45.834938955 -0500
> +++ b/drivers/scsi/aacraid/aachba.c 2008-02-06
> 16:32:01.109035329 -0500
> @@ -865,7 +865,7 @@
> u32 residue)
> {
> - sense_buf[0] = 0xF0; /* Sense data valid, err
> code 70h (current error) */
> + sense_buf[0] = 0x70; /* Sense data invalid, err
> code 70h (current error) */
> sense_buf[1] = 0; /* Segment number, always
> zero */
>
> if (incorrect_length) {
>
> This patch is against current scsi-misc-2.6
>
> ObligatoryDisclaimer: Please accept my condolences
> regarding Outlook's handling of patch attachments.
> Please use the attached patch and not any inline content.
>
> Signed-off-by: Mark Salyzyn <[EMAIL PROTECTED]>
>
> drivers/scsi/aacraid/aachba.c | 81
> +++++++++++++++---------------------------
> 1 file changed, 30 insertions(+), 51 deletions(-)
>
> Sincerely -- Mark Salyzyn
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
