James, This patch seem to be fine. Please consider this patch as Acked-by: "Sreekanth Reddy" <[email protected]>
Regards, Sreekanth > -----Original Message----- > From: [email protected] [mailto:linux-scsi- > [email protected]] On Behalf Of Martin K. Petersen > Sent: Wednesday, August 29, 2012 12:00 AM > To: [email protected] > Cc: [email protected]; Martin K. Petersen; > Nandigama, Nagalakshmi; Moore, Eric > Subject: [PATCH 5/5] mpt2sas: Add a module parameter that permits > overriding protection capabilities > > From: "Martin K. Petersen" <[email protected]> > > Add a parameter that allows the host protection capabilities mask to be > provided at module load time. > > Signed-off-by: Martin K. Petersen <[email protected]> > Cc: [email protected] > Cc: [email protected] > --- > drivers/scsi/mpt2sas/mpt2sas_scsih.c | 15 +++++++++++++-- > 1 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c > b/drivers/scsi/mpt2sas/mpt2sas_scsih.c > index bfda0ec..96f4d1f 100644 > --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c > +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c > @@ -123,6 +123,11 @@ static int disable_discovery = -1; > module_param(disable_discovery, int, 0); > MODULE_PARM_DESC(disable_discovery, " disable discovery "); > > +/* permit overriding the host protection capabilities mask (EEDP/T10 > PI) */ > +static int prot_mask = 0; > +module_param(prot_mask, int, 0); > +MODULE_PARM_DESC(prot_mask, " host protection capabilities mask, def=7 > "); > + > /** > * struct sense_info - common structure for obtaining sense keys > * @skey: sense key > @@ -8088,8 +8093,14 @@ _scsih_probe(struct pci_dev *pdev, const struct > pci_device_id *id) > goto out_add_shost_fail; > } > > - scsi_host_set_prot(shost, SHOST_DIF_TYPE1_PROTECTION > - | SHOST_DIF_TYPE2_PROTECTION | SHOST_DIF_TYPE3_PROTECTION); > + /* register EEDP capabilities with SCSI layer */ > + if (prot_mask) > + scsi_host_set_prot(shost, prot_mask); > + else > + scsi_host_set_prot(shost, SHOST_DIF_TYPE1_PROTECTION > + | SHOST_DIF_TYPE2_PROTECTION > + | SHOST_DIF_TYPE3_PROTECTION); > + > scsi_host_set_guard(shost, SHOST_DIX_GUARD_CRC); > > /* event thread */ > -- > 1.7.7.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" > in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
