On Wed, Oct 10, 2012 at 02:35:47PM -0400, Alan Stern wrote: > On Wed, 10 Oct 2012, Aaron Lu wrote: > > > Update sd driver to use the callbacks defined in dev_pm_ops. > > > > sd_freeze is NULL, the bus level callback has taken care of quiescing > > the device so there should be nothing needs to be done here. > > Consequently, sd_thaw is not needed here either. > > > > Both suspend and poweroff shares the same routine sd_suspend, which will > > sync flush and then stop the drive, this is the same as before. > > > > sd_runtime_suspend also uses sd_suspend, so when a scsi disk is runtime > > suspended, it will be placed to stopped power state. > > This is not the same as before. The existing code does not spin down > the disk during runtime suspend. > > Now maybe it should -- I don't know. The point is that this patch > makes two separate changes, which is generally not a good idea.
Agree. Will seperate, thanks. -Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
