Hello, Bart.
On Tue, Oct 23, 2012 at 02:16:12PM +0200, Bart Van Assche wrote:
> On 10/17/12 01:51, Tejun Heo wrote:
> >>-void blk_drain_queue(struct request_queue *q, bool drain_all)
> >>+static void blk_drain_queue(struct request_queue *q, bool drain_all)
> >> {
> >> int i;
> >>
> >> while (true) {
> >>- bool drain = false;
> >>+ int drain = 0;
> >
> >I don't think this is necessary. bool conversion works fine
> >regardless how high the bits are. Isn't avoiding signed/unsigned
> >autocast maze one of the reasons why we're using bool to begin with?
>
> My concern is about statements like "drain |= q->nr_rqs[i]". As far
> as I know nr_rqs can exceed the value 255 ?
How would that be a problem? Can you please elaborate (or better
demonstrate) the problem case? And if such problem exists, please
make it a separate bug fix patch.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
