On 12/2/2012 5:21 PM, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> This removes an open coded simple_open() function and
> replaces file operations references to the function
> with simple_open() instead.
>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/scsi/csiostor/csio_init.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/scsi/csiostor/csio_init.c
> b/drivers/scsi/csiostor/csio_init.c
> index fdd408f..17cf5e1 100644
> --- a/drivers/scsi/csiostor/csio_init.c
> +++ b/drivers/scsi/csiostor/csio_init.c
> @@ -57,16 +57,6 @@ static struct dentry *csio_debugfs_root;
> static struct scsi_transport_template *csio_fcoe_transport;
> static struct scsi_transport_template *csio_fcoe_transport_vport;
>
> -/*
> - * debugfs support
> - */
Please retain this comment - it is needed for the rest of the debugfs code.
> -static int
> -csio_mem_open(struct inode *inode, struct file *file)
> -{
> - file->private_data = inode->i_private;
> - return 0;
> -}
> -
> static ssize_t
> csio_mem_read(struct file *file, char __user *buf, size_t count, loff_t
> *ppos)
> {
> @@ -110,7 +100,7 @@ csio_mem_read(struct file *file, char __user *buf, size_t
> count, loff_t *ppos)
>
> static const struct file_operations csio_mem_debugfs_fops = {
> .owner = THIS_MODULE,
> - .open = csio_mem_open,
> + .open = simple_open,
It would be nice if you could indent this per the rest of the structure
members. The patch looks good otherwise.
Thanks!
Naresh.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
