> -----Original Message----- > From: Dan Carpenter [mailto:[email protected]] > Sent: Friday, March 08, 2013 4:01 AM > To: Anil Gurumurthy > Cc: Vijay Mohan Guvva; James E.J. Bottomley; [email protected]; > [email protected]; [email protected] > Subject: [patch] [SCSI] bfa: Use GFP_ATOMIC under spin_lock > > This is always called with spinlocks held so it should use GFP_ATOMIC. The > call tree is: > > -> bfad_drv_start() > Takes spin_lock_irqsave(&bfad->bfad_lock, flags); > -> bfa_fcs_pbc_vport_init() > -> bfa_fcb_pbc_vport_create() > > Signed-off-by: Dan Carpenter <[email protected]> > > diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c index > a5f7690..d144a06 100644 > --- a/drivers/scsi/bfa/bfad.c > +++ b/drivers/scsi/bfa/bfad.c > @@ -491,7 +491,7 @@ bfa_fcb_pbc_vport_create(struct bfad_s *bfad, > struct bfi_pbc_vport_s pbc_vport) > struct bfad_vport_s *vport; > int rc; > > - vport = kzalloc(sizeof(struct bfad_vport_s), GFP_KERNEL); > + vport = kzalloc(sizeof(struct bfad_vport_s), GFP_ATOMIC); > if (!vport) { > bfa_trc(bfad, 0); > return;
Changes looks good. Thanks for the patch. Acked-by: Vijay Mohan Guvva <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
