On Fri, 24 May 2013 11:50:47 +0200, Hannes Reinecke wrote: > > The 'eh_entry' list might be used even before scsi_softirq_done() > is called. Hence we should rather initialize it together with > the other eh-related variables. > > Signed-off-by: Hannes Reinecke <h...@suse.de> > --- > drivers/scsi/scsi_lib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c > index c31187d..a5515ec 100644 > --- a/drivers/scsi/scsi_lib.c > +++ b/drivers/scsi/scsi_lib.c > @@ -318,6 +318,8 @@ static void scsi_init_cmd_errh(struct scsi_cmnd *cmd) > memset(cmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE); > if (cmd->cmd_len == 0) > cmd->cmd_len = scsi_command_size(cmd->cmnd); > + INIT_LIST_HEAD(&cmd->eh_entry); > + cmd->eh_eflags = 0;
I always suspect something subtle going on when a variable is initialized to 0 three lines below a memset. Can line this go away? Jörn -- Those who come seeking peace without a treaty are plotting. -- Sun Tzu -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
