On Sun, Jun 2, 2013 at 9:34 AM, Akinobu Mita <[email protected]> wrote: > In UIC error interrupt handling, it checks if UIC data link layer error > code indicates PA_INIT_ERROR in order to determine whether a fatal error > handling is needed or not. > > But the code tries to read UIC data link layer error code from wrong > REG_UIC_ERROR_CODE_PHY_ADAPTER_LAYER, it should be > REG_UIC_ERROR_CODE_DATA_LINK_LAYER. > > Signed-off-by: Akinobu Mita <[email protected]> > Cc: Vinayak Holikatti <[email protected]> > Cc: Santosh Y <[email protected]> > Cc: "James E.J. Bottomley" <[email protected]> > Cc: [email protected] > --- > drivers/scsi/ufs/ufshcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index c32a478..492f2b7 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -1246,7 +1246,7 @@ static void ufshcd_err_handler(struct ufs_hba *hba) > if (hba->errors & UIC_ERROR) { > > reg = readl(hba->mmio_base + > - REG_UIC_ERROR_CODE_PHY_ADAPTER_LAYER); > + REG_UIC_ERROR_CODE_DATA_LINK_LAYER); > if (reg & UIC_DATA_LINK_LAYER_ERROR_PA_INIT) > goto fatal_eh; > } > -- > 1.8.1.4 >
Acked-by: Santosh Y <[email protected]> -- ~Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
