On 5/30/13 12:50 AM, "Dan Carpenter" <[email protected]> wrote:
>There is an unlock missing if the == FNIC_IOREQ_ABTS_PENDING is >false. > >Signed-off-by: Dan Carpenter <[email protected]> >--- >Static analysis. I can't test this. > >diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c >index be99e75..a97e6e5 100644 >--- a/drivers/scsi/fnic/fnic_scsi.c >+++ b/drivers/scsi/fnic/fnic_scsi.c >@@ -2432,11 +2432,9 @@ int fnic_is_abts_pending(struct fnic *fnic, struct >scsi_cmnd *lr_sc) > "Found IO in %s on lun\n", > fnic_ioreq_state_to_str(CMD_STATE(sc))); > >- if (CMD_STATE(sc) == FNIC_IOREQ_ABTS_PENDING) { >- spin_unlock_irqrestore(io_lock, flags); >+ if (CMD_STATE(sc) == FNIC_IOREQ_ABTS_PENDING) > ret = 1; >- continue; >- } >+ spin_unlock_irqrestore(io_lock, flags); > } > > return ret; Tested-by: Hiral Patel <[email protected]> Acked-by: Hiral Patel <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
