On Tue, Jul 09, 2013 at 12:47:37PM -0700, Robert Love wrote: > ctlr_dev was initialized to NULL, and never re-assigned. This > caused the log statement to always report failure. This patch > removes the unused variable and fixes the log statement to always > report 'success', as that is what should be logged if the code > reaches this point. > > Signed-off-by: Robert Love <[email protected]> > Tested-by: Jack Morgan <[email protected]> > Acked-by: Neil Horman <[email protected]> > --- > drivers/scsi/fcoe/fcoe_transport.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/fcoe/fcoe_transport.c > b/drivers/scsi/fcoe/fcoe_transport.c > index bedd422..f1ae5ed 100644 > --- a/drivers/scsi/fcoe/fcoe_transport.c > +++ b/drivers/scsi/fcoe/fcoe_transport.c > @@ -707,7 +707,6 @@ ssize_t fcoe_ctlr_create_store(struct bus_type *bus, > { > struct net_device *netdev = NULL; > struct fcoe_transport *ft = NULL; > - struct fcoe_ctlr_device *ctlr_dev = NULL; > int rc = 0; > int err; > > @@ -754,9 +753,8 @@ ssize_t fcoe_ctlr_create_store(struct bus_type *bus, > goto out_putdev; > } > > - LIBFCOE_TRANSPORT_DBG("transport %s %s to create fcoe on %s.\n", > - ft->name, (ctlr_dev) ? "succeeded" : "failed", > - netdev->name); > + LIBFCOE_TRANSPORT_DBG("transport %s succeeded to create fcoe on %s.\n", > + ft->name, netdev->name); > > out_putdev: > dev_put(netdev); > >
Acked-by: Neil Horman <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
