On Mon, July 29, 2013, Subhash Jadavani wrote: > On 7/26/2013 7:16 PM, Seungwon Jeon wrote: > > Except for 'GOOD' and 'CHECK CONDITION', other status value > This is what UFS device spec says: "A GOOD status indicates successful > SCSI completion and therefore no Sense Data will be returned." So please > change the commit text accordingly. Ok. It may seem vague.
> > in Response UPIU may or may contain sense data. If a non-zero > > s/"may or may contain ..."/"may or may not contain" Yes. > > value is in the Data Segment Length field, it means that UPIU > > has Sense Data in the Data Segment area. > > > > Signed-off-by: Seungwon Jeon <[email protected]> > > --- > > drivers/scsi/ufs/ufs.h | 1 + > > drivers/scsi/ufs/ufshcd.c | 27 +++++++++++++++++++-------- > > 2 files changed, 20 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h > > index 139bc06..737c31b 100644 > > --- a/drivers/scsi/ufs/ufs.h > > +++ b/drivers/scsi/ufs/ufs.h > > @@ -114,6 +114,7 @@ enum { > > MASK_SCSI_STATUS = 0xFF, > > MASK_TASK_RESPONSE = 0xFF00, > > MASK_RSP_UPIU_RESULT = 0xFFFF, > > + MASK_RSP_UPIU_DATA_SEG_LEN = 0xFFFF, > > }; > > > > /* Task management service response */ > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > > index 4cf3a2d..688ae0e 100644 > > --- a/drivers/scsi/ufs/ufshcd.c > > +++ b/drivers/scsi/ufs/ufshcd.c > > @@ -218,6 +218,20 @@ ufshcd_get_rsp_upiu_result(struct utp_upiu_rsp > > *ucd_rsp_ptr) > > return be32_to_cpu(ucd_rsp_ptr->header.dword_1) & MASK_RSP_UPIU_RESULT; > > } > > > > +/* > > + * ufshcd_get_rsp_upiu_data_seg_len - Get the data segment length > > + * from response UPIU > > + * @ucd_rsp_ptr: pointer to response UPIU > > + * > > + * Return the data segment length. > > + */ > > +static inline int > > +ufshcd_get_rsp_upiu_data_seg_len(struct utp_upiu_rsp *ucd_rsp_ptr) > > +{ > > + return be32_to_cpu(ucd_rsp_ptr->header.dword_2) & > > + MASK_RSP_UPIU_DATA_SEG_LEN; > > +} > > + > > /** > > * ufshcd_config_int_aggr - Configure interrupt aggregation values. > > * Currently there is no use case where we want to > > configure > > @@ -298,7 +312,8 @@ void ufshcd_send_command(struct ufs_hba *hba, unsigned > > int task_tag) > > static inline void ufshcd_copy_sense_data(struct ufshcd_lrb *lrbp) > > { > > int len; > > - if (lrbp->sense_buffer) { > > + if (lrbp->sense_buffer && > > + !ufshcd_get_rsp_upiu_data_seg_len(lrbp->ucd_rsp_ptr)) { > > why if(!data_seg_len)? I guess you want to copy the sense data tot sense > buffer only if the data segment length is non zero so in that case it > should be "if(data_seg_len)". Correct. Thanks, Seungwon Jeon -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
