From: Bodo Stroesser <[email protected]> Date: Mon, 2 Dec 2013 18:52:10 +0100 Subject: [PATCH 2/3] st.ko: remove unnecessary normalize_buffer
This patch removes an unnecessary call to normalize_buffer() in enlarge_buffer() In st_open() always a buffer of one page is allocated. When the buffer needs to be enlarged later, it does not make sense to free this page unconditionally. Cc: Kai Makisara <[email protected]> Signed-off-by: Bodo Stroesser <[email protected]> --- --- a/drivers/scsi/st.c 2013-12-02 18:52:10.000000000 +0100 +++ b/drivers/scsi/st.c 2013-12-02 18:52:10.000000000 +0100 @@ -3725,9 +3725,6 @@ static int enlarge_buffer(struct st_buff if (new_size <= STbuffer->buffer_size) return 1; - if (STbuffer->buffer_size <= PAGE_SIZE) - normalize_buffer(STbuffer); /* Avoid extra segment */ - max_segs = STbuffer->use_sg; priority = GFP_KERNEL | __GFP_NOWARN;
