On 26/05/14 8:51 pm, "Benoit Taine" <[email protected]> wrote:
>This issue was reported by coccicheck using the semantic patch >at scripts/coccinelle/api/memdup.cocci > >Signed-off-by: Benoit Taine <[email protected]> >--- >Tested by compilation without errors. > > drivers/scsi/qla4xxx/ql4_os.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > >diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c >index 9eef7d4..3202063 100644 >--- a/drivers/scsi/qla4xxx/ql4_os.c >+++ b/drivers/scsi/qla4xxx/ql4_os.c >@@ -3565,14 +3565,13 @@ static int qla4xxx_copy_from_fwddb_param(struct >iscsi_bus_flash_session *sess, > if (test_bit(OPT_IPV6_DEVICE, &options)) { > conn->ipv6_traffic_class = fw_ddb_entry->ipv4_tos; > >- conn->link_local_ipv6_addr = kzalloc(IPv6_ADDR_LEN, GFP_KERNEL); >+ conn->link_local_ipv6_addr = kmemdup( >+ fw_ddb_entry->link_local_ipv6_addr, >+ IPv6_ADDR_LEN, GFP_KERNEL); > if (!conn->link_local_ipv6_addr) { > rc = -ENOMEM; > goto exit_copy; > } >- >- memcpy(conn->link_local_ipv6_addr, >- fw_ddb_entry->link_local_ipv6_addr, IPv6_ADDR_LEN); > } else { > conn->ipv4_tos = fw_ddb_entry->ipv4_tos; > } Acked-by: Vikas Chaudhary <[email protected]>
<<attachment: winmail.dat>>
