On Fri, Aug 01, 2014 at 08:27:05AM +0200, jgr...@suse.com wrote: > From: Juergen Gross <jgr...@suse.com> > > If a scsi host driver specifies .cmd_len in it's scsi_host_template, a > driver's > private command pool is needed. scsi_find_host_cmd_pool() will locate it, but > scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template. > > This will result in an access error when the host is removed. > > Avoid the problem by saving the address of a new allocated command pool where > it is expected. > > Signed-off-by: Juergen Gross <jgr...@suse.com>
Looks good, but minor nitpick below: > + if (shost->hostt->cmd_size) > + shost->hostt->cmd_pool = pool; > + We already have a local hostt variable for the host template in this function, please use it. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
