On 09/10/2014 05:06 PM, Elliott, Robert (Server Storage) wrote:
>> From: [email protected] [mailto:linux-scsi-
>> [email protected]] On Behalf Of Sumit Saxena
>>
>>> From: Tomas Henzl [mailto:[email protected]]
>>>
>>> With several controllers in a system this may take a lot memory,
>>> could you also in case when a kdump kernel is running lower it,
>>> by not using this feature?
>>>
>> Agreed, we will disable this feature for kdump kernel by adding
>> "reset_devices" global varaiable.
>> That check is required for only one place, throughout the code, this
>> feature will remain disabled. Code snippet for the same-
>>
>> instance->crash_dump_drv_support = (!reset_devices) &&
>> crashdump_enable &&
>> instance->crash_dump_fw_support &&
>> instance->crash_dump_buf);
>> if(instance->crash_dump_drv_support) {
>> printk(KERN_INFO "megaraid_sas: FW Crash dump is
>> supported\n");
>> megasas_set_crash_dump_params(instance,
>> MR_CRASH_BUF_TURN_OFF);
>>
>> } else {
>> ..
>> }
> Network drivers have been running into similar problems.
>
> There's a new patch from Amir coming through net-next to make
> is_kdump_kernel() (in crash_dump.h) accessible to modules.
> That may be a better signal than reset_devices that the
> driver should use minimal resources.
>
> http://comments.gmane.org/gmane.linux.network/324737
>
> I'm not sure about the logistics of a SCSI patch depending
> on a net-next patch.
Probably better to start with reset_devices and switch to is_kdump_kernel()
later.
This is not a discussion about reset_devices versus is_kdump_kernel, but
while it looks good to have it distinguished - is the reset_devices actually
used anywhere else than in kdump kernel?
>
> ---
> Rob Elliott HP Server Storage
>
>
>
>
> N�����r��y���b�X��ǧv�^�){.n�+����{���"�{ay� ʇڙ�,j��f���h���z� �w���
> ���j:+v���w�j�m��������zZ+�����ݢj"��!tml=
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
