On 09/16/2014 08:35 AM, Randy Dunlap wrote:
From: Randy Dunlap <[email protected]>
There are other kconfig symbols which select SCSI_FC_ATTRS,
so they also need to depend on NET to fix kconfig warnings and
build errors:
warning: (LIBFC && SCSI_IBMVFC && SCSI_QLA_FC && SCSI_LPFC && ZFCP && SCSI_BFA_FC &&
SCSI_CHELSIO_FCOE && FUSION_FC) selects SCSI_FC_ATTRS which has unmet direct dependencies (SCSI && NET)
drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_event':
drivers/scsi/scsi_transport_fc.c:543:7: error: 'scsi_nl_sock' undeclared (first
use in this function)
drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_vendor_event':
drivers/scsi/scsi_transport_fc.c:611:7: error: 'scsi_nl_sock' undeclared (first
use in this function)
Reported-by: Fengguang Wu <[email protected]> [0-day test robot]
Signed-off-by: Randy Dunlap <[email protected]>
---
drivers/message/fusion/Kconfig | 2 +-
drivers/scsi/Kconfig | 9 +++++----
drivers/scsi/csiostor/Kconfig | 2 +-
drivers/scsi/qla2xxx/Kconfig | 2 +-
4 files changed, 8 insertions(+), 7 deletions(-)
--- lnx-317-rc5.orig/drivers/scsi/Kconfig
+++ lnx-317-rc5/drivers/scsi/Kconfig
@@ -1675,7 +1676,7 @@ config SCSI_SUNESP
config ZFCP
tristate "FCP host bus adapter driver for IBM eServer zSeries"
- depends on S390 && QDIO && SCSI
+ depends on S390 && QDIO && SCSI && NET
select SCSI_FC_ATTRS
help
If you want to access SCSI devices attached to your IBM eServer
I think zfcp does not have any (direct) dependency on NET.
It looks like SCSI_FC_ATTRS selects SCSI_NETLINK (declaring
scsi_nl_sock) and only depends on SCSI but not on NET.
SCSI_NETLINK itself only selects NET but does not model its direct
depencency on NET?
Do I understand correctly, that the only solution is to make all
INdirect (transitive) dependencies explicit with the LLDDs instead of
making the direct exploiter SCSI_NETLINK(?) depend on NET?
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on System z Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
