On 9/26/14, 8:08 AM, "Dan Carpenter" <[email protected]> wrote:
>Hello Himanshu Madhani,
>
>The patch df57cabac41f: "qla2xxx: Add FDMI-2 functionality." from Sep
>25, 2014, leads to the following static checker warnings:
>
>drivers/scsi/qla2xxx/qla_gs.c:1339 qla2x00_fdmi_rhba() error: snprintf()
>chops off the last chars of 'ha->model_number': 17 vs 16
>drivers/scsi/qla2xxx/qla_gs.c:1628 qla2x00_fdmi_rpa() error: snprintf()
>chops off the last chars of 'p_sysid->nodename': 65 vs 32
>drivers/scsi/qla2xxx/qla_gs.c:1631 qla2x00_fdmi_rpa() error: snprintf()
>chops off the last chars of
>'(((vha->host)->shost_data)->system_hostname)': 256 vs 32
>drivers/scsi/qla2xxx/qla_gs.c:1763 qla2x00_fdmiv2_rhba() error:
>snprintf() chops off the last chars of 'ha->model_number': 17 vs 16
>drivers/scsi/qla2xxx/qla_gs.c:2195 qla2x00_fdmiv2_rpa() error: snprintf()
>chops off the last chars of 'p_sysid->nodename': 65 vs 32
>drivers/scsi/qla2xxx/qla_gs.c:2198 qla2x00_fdmiv2_rpa() error: snprintf()
>chops off the last chars of
>'(((vha->host)->shost_data)->system_hostname)': 256 vs 32
>
>drivers/scsi/qla2xxx/qla_gs.c
> 2194 if (p_sysid) {
> 2195 snprintf(eiter->a.host_name,
>sizeof(eiter->a.host_name),
> 2196 "%s", p_sysid->nodename);
>
>We're chopping most of the hostname off. That seems bad.
>
> 2197 } else {
> 2198 snprintf(eiter->a.host_name,
>sizeof(eiter->a.host_name),
> 2199 "%s", fc_host_system_hostname(vha->host));
> 2200 }
Thanks for the update Dan, Will send a fix soon.
>
>regards,
>dan carpenter
<<attachment: winmail.dat>>
