On 09/07/14 18:31, Christoph Hellwig wrote:
Move the error handling path out of scsi_io_completion and into an out of line helper.Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/scsi/scsi_lib.c | 263 +++++++++++++++++++++++++----------------------- 1 file changed, 136 insertions(+), 127 deletions(-) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 2221bf1..cc5d404 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -742,6 +742,132 @@ static int __scsi_error_from_host_byte(struct scsi_cmnd *cmd, int result) return error; } +static noinline bool +scsi_handle_ioerror(struct scsi_cmnd *cmd, int result, + struct scsi_sense_hdr *sshdr)
Please document the meaning of the return value of this function and also why it has been marked noinline. Otherwise I'm fine with this patch.
Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
