On 11/06/2014 08:20 AM, Christoph Hellwig wrote: > On Tue, Nov 04, 2014 at 09:06:49AM +0100, Hannes Reinecke wrote: >> One statement was missing from the conversion to dev_printk(). >> >> Signed-off-by: Hannes Reinecke <[email protected]> >> --- >> drivers/scsi/scsi.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c >> index 92d5912..9880b59 100644 >> --- a/drivers/scsi/scsi.c >> +++ b/drivers/scsi/scsi.c >> @@ -541,10 +541,12 @@ void scsi_log_send(struct scsi_cmnd *cmd) >> "Send: scmd 0x%p\n", cmd); >> scsi_print_command(cmd); >> if (level > 3) { >> - printk(KERN_INFO "buffer = 0x%p, bufflen = %d," >> - " queuecommand 0x%p\n", >> - scsi_sglist(cmd), scsi_bufflen(cmd), >> - cmd->device->host->hostt->queuecommand); >> + struct Scsi_Host *shost = cmd->device->host; >> + scmd_printk(KERN_INFO, cmd, >> + "buffer = 0x%p, bufflen = %d," >> + " queuecommand 0x%p\n", >> + scsi_sglist(cmd), scsi_bufflen(cmd), >> + shost->hostt->queuecommand); > > This printk doesn't look very useful, I'd rather kill it. > Be my guest.
I'm planning on removing all the references to command pointers anyway, but for that I'll need a consistent scsi command enumeration. Your tcq rework should help for that. But that will be done in a later patch series. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
