On Wed, 2015-01-14 at 10:36 +0100, h...@lst.de wrote: > On Tue, Jan 13, 2015 at 06:56:17PM +0000, James Bottomley wrote: > > I really hate using an on-stack buffer here ... we're pretty deep in the > > call chain already. > > > > Since it's just required for printing a "command: " prefix, why not just > > use scsi_print_command()? > > Both the ch and sr callers are not really a problem in terms of stack > usage, as they are directly in file operations of character or block > devices, so the whole FS/MM stack stack problem isn't an issue.
Trying to calculate minutely how much additional overhead there is isn't really the point. The point is we can just use a different function that doesn't consume the on stack buffer, so we should, just as a matter of best practise. I agree it would have been a more finely balanced problem if we definitely needed the allocation > But using higher level functions might still be useful here. James
