On Thu, 2015-01-15 at 13:28 +0200, Andy Shevchenko wrote: > Instead of pushing each byte via stack let's use custom specifier which allows > to print small buffers as a hex string. > > Signed-off-by: Andy Shevchenko <[email protected]> > --- > drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c > b/drivers/scsi/qla2xxx/tcm_qla2xxx.c > index 73f9fee..99f43b7 100644 > --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c > +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c > @@ -1570,9 +1570,7 @@ static int tcm_qla2xxx_check_initiator_node_acl( > * match the format by tcm_qla2xxx explict ConfigFS NodeACLs. > */ > memset(&port_name, 0, 36); > - snprintf(port_name, 36, "%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x", > - fc_wwpn[0], fc_wwpn[1], fc_wwpn[2], fc_wwpn[3], fc_wwpn[4], > - fc_wwpn[5], fc_wwpn[6], fc_wwpn[7]); > + snprintf(port_name, sizeof(port_name), "%8phC", fc_wwpn); > /* > * Locate our struct se_node_acl either from an explict NodeACL created > * via ConfigFS, or via running in TPG demo mode.
Picking this one up, since it's specific to tcm_qla2xxx code. Applied to target-pending/for-next. Thanks Andy! --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
