On Thu, 2015-01-29 at 16:56 -0800, Andy Grover wrote: > A great many SCSI codes can be made available to userspace in a uapi > header, while the kernel-only definitions stay in scsi/scsi.h. > > This will permit userspace apps to stop using the antiquated definitions > available in glibc's scsi/scsi.h, which are very old and incomplete. > > scsi/scsi.h also includes uapi/scsi/scsi.h so kernel code need not update > includes. > > Signed-off-by: Andy Grover <agro...@redhat.com> > --- > include/scsi/scsi.h | 497 +-------------------------------------------- > include/uapi/linux/Kbuild | 1 + > include/uapi/linux/scsi.h | 506 > ++++++++++++++++++++++++++++++++++++++++++++++
I think this is too much: lots of things in scsi.h have no meaning to the user: our internal definition of scsi_lun for instance, internal return codes, mid level queue instructions, our internal markers for SCSI levels ... What you put in this file becomes a contract for userspace. The rule should be don't put anything in unless we want the user to use it (and we're willing to stick by it). I really think that nothing that isn't already in /usr/include/scsi/scsi.h is a great rule to follow and then, if necessary, justify why any additional stuff. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
