On Sun, 1 Feb 2015, Michael Schmitz wrote:

> Finn, Nicholas,
> 
> > On Sat, 31 Jan 2015, Nicholas Mc Guire wrote:
> >
> > > This is only an API consolidation to make things more readable.
> > >
> > > Instances of var * HZ / 1000 are replaced by msecs_to_jiffies(var).
> >
> > ... and some instances of "value" are replaced by 
> > "msecs_to_jiffies(value)" which seems to be completely wrong.
> 
> The values for USLEEP_* are taken to be in units jiffies, according to 
> comments in NCR5380.c. Replacing them by the msecs_to_jiffies conversion 
> is in fact wrong.
> 
> Please drop the changes to g_NCR5380.c for that reason.
> 
> Cheers,
> 
>   Michael
> 

Yes, that's a better way to put it than my regrettably short-tempered 
message.

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to