Hi Hannes, Thank you for reviewing the patch. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal.
On 25/03/15 4:46 pm, "Hannes Reinecke" <[email protected]> wrote: >Hi Narsimhulu, > >On 03/11/2015 06:01 PM, Narsimhulu Musini wrote: >> Kconfig for kbuild >> Makefile to build snic module >> >> Updated MAINTAINERS file >> >> v2 >> Added compile time flags for debugfs dependent functionality. >> >> Signed-off-by: Narsimhulu Musini <[email protected]> >> Signed-off-by: Sesidhar Baddela <[email protected]> >> --- >> MAINTAINERS | 7 +++++++ >> drivers/scsi/Kconfig | 10 ++++++++++ >> drivers/scsi/Makefile | 1 + >> drivers/scsi/snic/Makefile | 21 +++++++++++++++++++++ >> 4 files changed, 39 insertions(+) >> create mode 100644 drivers/scsi/snic/Makefile >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 2a97e05..368fb76 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -2536,6 +2536,13 @@ L: [email protected] >> S: Supported >> F: drivers/scsi/fnic/ >> >> +CISCO SCSI HBA DRIVER >> +M: Narsimhulu Musini <[email protected]> >> +M: Sesidhar Baddela <[email protected]> >> +L: [email protected] >> +S: Supported >> +F: drivers/scsi/snic/ >> + >> CMPC ACPI DRIVER >> M: Thadeu Lima de Souza Cascardo <[email protected]> >> M: Daniel Oliveira Nascimento <[email protected]> >> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig >> index 9c92f41..7e9d80a 100644 >> --- a/drivers/scsi/Kconfig >> +++ b/drivers/scsi/Kconfig >> @@ -634,6 +634,16 @@ config FCOE_FNIC >> <file:Documentation/scsi/scsi.txt>. >> The module will be called fnic. >> >> +config SCSI_SNIC >> + tristate "Cisco SNIC Driver" >> + depends on PCI && SCSI && X86 >> + help >> + This is support for the Cisco PCI-Express SCSI HBA. >> + >> + To compile this driver as a module, choose M here and read >> + <file:Documentation/scsi/scsi.txt>. >> + The module will be called snic. >> + >> config SCSI_DMX3191D >> tristate "DMX3191D SCSI support" >> depends on PCI && SCSI >Please add an additional config section for enabling debugging >functionality; I'd rather not have it enabled automatically >depending on CONFIG_FS. Sure, I will add new config section. > >Cheers, > >Hannes >-- >Dr. Hannes Reinecke zSeries & Storage >[email protected] +49 911 74053 688 >SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg >GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton >HRB 21284 (AG Nürnberg) Thanks Narsimhulu > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
