>-----Original Message----- >From: Christoph Hellwig [mailto:[email protected]] >Sent: Tuesday, April 21, 2015 4:04 PM >To: [email protected] >Cc: [email protected]; [email protected]; >[email protected]; [email protected]; >[email protected]; [email protected] >Subject: Re: [PATCH RESEND 1/18] megaraid_sas : Add separate function for >setting up IRQs > >On Mon, Apr 20, 2015 at 06:02:30PM +0530, [email protected] >wrote: >> This patch will create separate function for setting up IRQs and enable >interrupts after adapter's initialization. > >The structure of megasas_setup_irqs clearly suggest it should be two >functions: one for the traditional case, and one for MSI-X. > >The irq unregister case should get a similar factoring.
Ok, I will create separate functions for setup_irqs- one for MSI-x and one for traditional case. Will refactor to create separate function for freeing IRQs. > >Additionally the changelog needs an explanation on why you move around >the code that registeres interrupts as well as the >->instancet->enable_intr call. Will resend the patch with explanation and three new functions(MSI-x setup, IO_APIC setup and freeing IRQs) added. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
