Hi James,
Thank you for reviewing the patches.
Sure, I will incorporate your comments and suggestions in next patch
submittal.
On 28/05/15 7:25 pm, "James Bottomley"
<james.bottom...@hansenpartnership.com> wrote:
>In general, patch is much better: it passes all the static checker tests
>for byte width and endianness issues. However
>
>On Wed, 2015-05-27 at 00:19 -0700, Narsimhulu Musini wrote:
>> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
>> index 9c92f41..8baab3f 100644
>> --- a/drivers/scsi/Kconfig
>> +++ b/drivers/scsi/Kconfig
>> @@ -634,6 +634,23 @@ config FCOE_FNIC
>> <file:Documentation/scsi/scsi.txt>.
>> The module will be called fnic.
>>
>> +config SCSI_SNIC
>> + tristate "Cisco SNIC Driver"
>> + depends on PCI && SCSI && X86_64
>
>Please don't restrict the compilation architecture in the Kconfig
>because that restricts the amount of build testing the driver gets.
>Instead you can put a runtime warning in the driver if you insist.
>Something like this
>
>http://thread.gmane.org/gmane.linux.scsi/101846
>
>Where you add a runtime taint is much better.
Sure, I will add runtime taint. Thanks for suggesting it.
>
>James
>
>
Thanks
Narsimhulu
>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
