On 06/11/2015 03:42 AM, [email protected] wrote:
> From: Rajinikanth Pandurangan <[email protected]>
> 
> Description:
>       Enable MSI interrupt mode for series-6 controller.
What seem problematic to me is that you still keep the module
option 'aac_msi' and a poor user might try
"IRQ handling. 0=PIC(default), 1=MSI, 2=MSI-X(unsupported, uses MSI)");
to manipulate the driver naturally withou any success.
Please either change the above description or add a new
option so it is not confusing.

Btw msi-x is now supported?

Cheers,
Tomas


> 
> Signed-off-by: Rajinikanth Pandurangan <[email protected]>
> ---
>  drivers/scsi/aacraid/src.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
> index b147341..eb07b3d 100644
> --- a/drivers/scsi/aacraid/src.c
> +++ b/drivers/scsi/aacraid/src.c
> @@ -742,7 +742,7 @@ int aac_src_init(struct aac_dev *dev)
>       if (dev->comm_interface != AAC_COMM_MESSAGE_TYPE1)
>               goto error_iounmap;
>  
> -     dev->msi = aac_msi && !pci_enable_msi(dev->pdev);
> +     dev->msi = !pci_enable_msi(dev->pdev);
>  
>       dev->aac_msix[0].vector_no = 0;
>       dev->aac_msix[0].dev = dev;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to