On 07/09/2015 10:24 AM, Christoph Hellwig wrote: > On Wed, Jul 08, 2015 at 11:07:05AM +0200, Hannes Reinecke wrote: >> As scsi_dh.c is now always compiled in we should be moving >> the 'dh_state' attribute to the generic code. >> >> Signed-off-by: Hannes Reinecke <[email protected]> > > Looks fine, but a few coding style nitpicks: > >> + if (!sdev->handler) { >> + /* >> + * Attach to a device handler >> + */ >> + err = scsi_dh_attach(sdev->request_queue, buf); >> + } else { >> + if (!strncmp(buf, "detach", 6)) { > > Switch to en else if here. Also mayべe move the activate case up as it's > relevant while detach is dead now. > Okay.
>> + return err<0?err:count; > > Please add the missing spaces here. > Will be doing so. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage [email protected] +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
