On 28.10.2015 23:05, Don Brace wrote: > The driver is using two MACROs which seemingly are looking in > the wrong location for the device_flags returned from > CISS_REPORT_PHYS. Both MACROs, NON_DISK_PHYS_DEV and > PHYS_IOACCEL, are using the pointer returned from figure_lunaddrbytes > which is the address of the LUN.lunid element in > the extended CISS_REPORT_PHYS. But the MACROS are using offsets > beyond the range of the element (offset 17 of an 8 byte element). > > These MACROs actually are looking at the correct location but > they fail static checker analysis. It also will not work > if any new elements are added to the extended LUN structure. > > Change the code to use the structure elements directly > since this MACRO is only used in one location. > > Reported-by: Dan Carpenter <dan.carpen...@oracle.com> > Reviewed-by: Scott Teel <scott.t...@pmcs.com> > Reviewed-by: Justin Lindley <justin.lind...@pmcs.com> > Reviewed-by: Kevin Barnett <kevin.barn...@pmcs.com> > Signed-off-by: Don Brace <don.br...@pmcs.com>
Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
