> +struct alua_dh_data {
> + struct alua_port_group *pg;
> + int group_id;
Keeping the group id here seem odd. It gets cleaned up later
in the series, so this is just a nitpick.
> -static int realloc_buffer(struct alua_dh_data *h, unsigned len)
> +static int realloc_buffer(struct alua_port_group *pg, unsigned len)
> {
> - if (h->buff && h->buff != h->inq)
> - kfree(h->buff);
> + if (pg->buff && pg->buff != pg->inq)
> + kfree(pg->buff);
>
> - h->buff = kmalloc(len, GFP_NOIO);
> - if (!h->buff) {
> - h->buff = h->inq;
> - h->bufflen = ALUA_INQUIRY_SIZE;
> + pg->buff = kmalloc(len, GFP_NOIO);
> + if (!pg->buff) {
> + pg->buff = pg->inq;
> + pg->bufflen = ALUA_INQUIRY_SIZE;
> return 1;
> }
> - h->bufflen = len;
> + pg->bufflen = len;
> return 0;
> }
All this disappears in the next patch, wouldn't it have been smarted
to move the next one before this one?
> /*
> + * alua_get_pg - Allocate a new port_group structure
> + * @sdev: scsi device
> + * @h: alua device_handler data
> + * @group_id: port group id
> + *
> + * Allocate a new port_group structure for a given
> + * device.
> + */
> +struct alua_port_group *alua_get_pg(struct scsi_device *sdev,
> + int group_id, int tpgs)
Can you call this alua_alloc_pg, please?
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
