On Fri, 2016-03-18 at 09:01 +0100, Hannes Reinecke wrote: > For fixed sense the information field is 32 bits, to we need > to truncate the information field to avoid clobbering the > sense code. > > Signed-off-by: Hannes Reinecke <[email protected]> > --- > drivers/scsi/scsi_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/scsi_common.c b/drivers/scsi/scsi_common.c > index c126966..3459009 100644 > --- a/drivers/scsi/scsi_common.c > +++ b/drivers/scsi/scsi_common.c > @@ -279,7 +279,7 @@ int scsi_set_sense_information(u8 *buf, int buf_len, u64 > info) > put_unaligned_be64(info, &ucp[4]); > } else if ((buf[0] & 0x7f) == 0x70) { > buf[0] |= 0x80; > - put_unaligned_be64(info, &buf[3]); > + put_unaligned_be32((u32)info, &buf[3]); > } > > return 0;
Well, not clobbering the ADDITIONAL SENSE LENGTH field is good, however according to SPC-5 what we are really supposed to do here is not set the VALID bit (buf[0] |= 0x80) if the value to be returned can't be represented in 32 bits (and set the INFORMATION field to a "vendor specific" value, whatever that means). I'm not a T10 member so I don't have immediate access to what the earlier SPC revisions say. Reviewed-by: Ewan D. Milne <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
