On Fri, 1 Apr 2016, James Bottomley wrote:
On Fri, 2016-04-01 at 10:06 -0400, Chad Dupuis wrote:
On Fri, 1 Apr 2016, Johannes Thumshirn wrote:
On 2016-04-01 15:10, Chad Dupuis wrote:
From: Joe Carnuccio <joe.carnuc...@qlogic.com>
Per customer request, add the following driver tunables:
o devloss_tmo
o max_luns
o queue_depth
o tm_timeout
Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com>
Signed-off-by: Chad Dupuis <chad.dup...@qlogic.com>
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 38
+++++++++++++++++++++++++++++++++++++-
drivers/scsi/bnx2fc/bnx2fc_io.c | 4 +++-
2 files changed, 40 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index d7029ea..600c29d 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@ -107,6 +107,26 @@ MODULE_PARM_DESC(debug_logging,
"\t\t0x10 - fcoe L2 fame related logs.\n"
"\t\t0xff - LOG all messages.");
+uint bnx2fc_devloss_tmo;
+module_param_named(devloss_tmo, bnx2fc_devloss_tmo, uint,
S_IRUGO);
+MODULE_PARM_DESC(devloss_tmo, " Change devloss_tmo for the
remote ports "
+ "attached via bnx2fc.");
+
+uint bnx2fc_max_luns = BNX2FC_MAX_LUN;
+module_param_named(max_luns, bnx2fc_max_luns, uint, S_IRUGO);
+MODULE_PARM_DESC(max_luns, " Change the default max_lun per SCSI
host. Default "
+ "0xffff.");
+
+uint bnx2fc_queue_depth;
+module_param_named(queue_depth, bnx2fc_queue_depth, uint,
S_IRUGO);
+MODULE_PARM_DESC(queue_depth, " Change the default queue depth
of
SCSI devices "
+ "attached via bnx2fc.");
+
+uint bnx2fc_tm_timeout = BNX2FC_TM_TIMEOUT;
+module_param_named(tm_timeout, bnx2fc_tm_timeout, uint,
S_IRUGO|S_IWUSR);
+MODULE_PARM_DESC(tm_timeout, " Change the default timeout for "
+ "task management commands. Default 60 seconds.");
+
Just a question, can't this be made dynamically adjustable via
sysfs instead
of a module parameter?
I presume you're talking about something like a
/sys/class/scsi_host/hostX/tm_timeout sysfs node?
Yes, but there's also the question of whether they should be generic
rather than bnx2fc specific. At least queue_depth, max_luns and
possibly tm_timeout would seem to belong to the SCSI host itself.
devloss_tmo looks like it should be a host parameter within the fc
transport class.
James
The use case for this is so that someone can administratively set these
parameters on driver load so that all devices discovered via our driver
will get these parameters set automatically usually via the
slave_configure callback. So functionally that's what is trying to
be accomplished with this patch and what we would be looking for in a
generic solution. Would the scsi_host_template and/or fc_host_template
be the appropriate place to set this then so the values could be
initialized during scsi_host/fc_host discovery?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
