On Wed, May 11, 2016 at 08:49:51PM -0500, Petros Koutoupis wrote: > Sumit, > > I will resubmit the patch with all the recommendations. Thank you. In case > you are interested, I have a crash file showcasing the error. I can always > provide this outside of this mailing thread. >
Please send it to the thread. To be honest, I totally can't understand this thread. Sumit says it is impossible and you are saying that you have seen it happen in real life. Are you using out of tree code or something? What are you doing that is unexpected? I don't see the point of adding a WARN_ON(). NULL derefs normally generate a pretty clear stack trace already (unless they are caused by memory corruption). Why are we not just fixing the bugs instead of warning and then crashing. Also when I'm doing static analysis people always tell me that "that bug is impossible, trust me." and instead of trusting people I really wish they would just show me the relevant code that prevents it from happening. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
