On 06/02/2016 07:39 AM, Hannes Reinecke wrote:
+int scsi_mq_resize_tags(struct Scsi_Host *shost, int max_tags)
+{
+       return blk_mq_resize_tag_set(&shost->tag_set, max_tags);
+}
+EXPORT_SYMBOL_GPL(scsi_mq_resize_tags);

What is the meaning of the max_tags argument? Does it include the reserved tag count or not? If not, shouldn't the number of reserved tags be added before calling blk_mq_resize_tag_set()? Please document the meaning of the max_tags argument.

Please also consider choosing a name for this function that is more consistent with the function names used in the block layer e.g. scsi_mq_update_tag_depth().

Thanks,

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to