On 06/14/2016 05:05 PM, Christoph Hellwig wrote: > Looks fine: > > Acked-by: Christoph Hellwig <[email protected]> > > But it should really go together with something like this: > > --- > From e54d1462ae244db3189a8b69018bc5f3e3d3b468 Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig <[email protected]> > Date: Tue, 14 Jun 2016 17:04:10 +0200 > Subject: scsi: move current_cmnd into the 53c700 driver > > The 53c700 driver is the only user of the current_cmnd field in > struct scsi_device, so let's move it into the driver private data. > > Signed-off-by: Christoph Hellwig <[email protected]> > --- > drivers/scsi/53c700.c | 8 +++++--- > drivers/scsi/53c700.h | 1 + > include/scsi/scsi_device.h | 1 - > 3 files changed, 6 insertions(+), 4 deletions(-) > Yes, please. I was wanting to get rid of the 'current_cmnd' thingie a long time ago.
Reviewed-by: Hannes Reinecke <[email protected]> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
