On 07/06/2016 09:36 PM, James Smart wrote: > > Fix SLI mode 2 config failure > > Signed-off-by: Dick Kennedy <[email protected]> > Signed-off-by: James Smart <[email protected]> > --- > drivers/scsi/lpfc/lpfc_sli.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c > index 6eef972..b1ddbaa 100644 > --- a/drivers/scsi/lpfc/lpfc_sli.c > +++ b/drivers/scsi/lpfc/lpfc_sli.c > @@ -4696,6 +4696,8 @@ lpfc_sli_hba_setup(struct lpfc_hba *phba) > "Not supported by adapter.\n"); > if (rc && mode != 2) > rc = lpfc_sli_config_port(phba, 2); > + else if (rc && mode == 2) > + rc = lpfc_sli_config_port(phba, 3); > if (rc) > goto lpfc_sli_hba_setup_error; > > Hmm. Maybe a code reorg here if (rc) { if (mode == 2) .. else .. goto ... }
would make things easier to read. But it's not that important. Reviewed-by: Hannes Reinecke <[email protected]> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
