On Fri, 2016-07-15 at 14:18 +0300, Dan Carpenter wrote: > My static checker complains that we need to unlock on this path. Seems > true. > > Signed-off-by: Dan Carpenter <[email protected]> > > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c > index fc523c3..ab67ec4 100644 > --- a/drivers/scsi/ibmvscsi/ibmvfc.c > +++ b/drivers/scsi/ibmvscsi/ibmvfc.c > @@ -4722,6 +4722,8 @@ static void ibmvfc_rport_add_thread(struct work_struct > *work) > tgt_dbg(tgt, "Setting rport roles\n"); > fc_remote_port_rolechg(rport, > tgt->ids.roles); > put_device(&rport->dev); > + } else { > + > spin_unlock_irqrestore(vhost->host->host_lock, flags); > } > > kref_put(&tgt->kref, ibmvfc_release_tgt); > --
Reviewed-by: Ewan D. Milne <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
