On Tue, 2016-12-27 at 21:19 -0500, Alan Stern wrote:
> On Tue, 27 Dec 2016, George Cherian wrote:
> > True. I am afraid that there necessarily is a window for resetting a
> > disconnected device. But the check you proposed is better.
> > however, I'd like to encapsulate that together with a test for
> > logical disconnect. Uas is unlikely to be the only driver that has
> > this issue.
>
> True enough. We could have a usb_device_is_disconnected() inline
> helper for this purpose. There's no need to try to distinguish
> between physical and logical disconnects, as far as I can see.
There is no such need. There is a need for both checks though.
> However, as George points out, the "Transfer event" error has nothing
> to do with disconnection. It was triggered by the device's bogus
> response to a REPORT OPCODES command, or something of the sort. We
> should be able to handle bogus responses without logging ERROR
> messages, because such messages indicate a bug in a kernel driver.
Indeed. We have two independent issues. We should have two independent
fixes.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
