> -----Original Message----- > From: Johannes Thumshirn [mailto:[email protected]] > Sent: Monday, January 30, 2017 1:38 AM > To: Raghava Aditya Renukunta > <[email protected]> > Cc: [email protected]; [email protected]; linux- > [email protected]; Dave Carroll <[email protected]>; Gana > Sridaran <[email protected]>; Scott Benesh > <[email protected]> > Subject: Re: [PATCH V3 06/24] aacraid: Reworked scsi command submission > path > > EXTERNAL EMAIL > > > On Fri, Jan 27, 2017 at 11:28:35AM -0800, Raghava Aditya Renukunta wrote: > > Moved the READ and WRITE switch cases to the top. Added a default > > case to the switch case and replaced duplicate scsi result value with a > > macro. > > > > Signed-off-by: Raghava Aditya Renukunta > <[email protected]> > > Signed-off-by: Dave Carroll <[email protected]> > > > > --- > > I really whished this one had a better commit message (not only explaining > what you've changes but also why you did it). > > But if this is the only issue there's hardly a reason to repost.
Oh let me rewrite the description to include the reasoning as well. Regards, Raghava Aditya > Reviewed-by: Johannes Thumshirn <[email protected]> > > -- > Johannes Thumshirn Storage > [email protected] +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
