Re: [PATCH v2 03/14] qla2xxx: Allow vref count to timeout on vport delete.

[Madhani, Himanshu]

On 2/8/17, 5:03 AM, "Christoph Hellwig" <h...@infradead.org> wrote:

>On Fri, Feb 03, 2017 at 02:40:44PM -0800, Himanshu Madhani wrote:
>> -    spin_lock_irqsave(&ha->vport_slock, flags);
>> -    while (atomic_read(&vha->vref_count)) {
>> -            spin_unlock_irqrestore(&ha->vport_slock, flags);
>> -
>> +    while (count-- && atomic_read(&vha->vref_count))
>>              msleep(500);
>
>Please add a wait queue to skeep on while waiting for vref_count to
>drop to zero.  

Thanks for the review. Will update patch and resend series.