On 02/21/2017 01:29 AM, Christoph Hellwig wrote:
> Without this drivers that don't clear the state themselves can see off
> effects. For example Hyper-V VMs using the storvsc driver will often
> hang during boot due to uncleared Test Unit Ready failures.
>
> Fixes: e9c787e6 ("scsi: allocate scsi_cmnd structures as part of struct
> request")
> Signed-off-by: Christoph Hellwig <[email protected]>
> Reported-by: Dexuan Cui <[email protected]>
> Tested-by: Dexuan Cui <[email protected]>
> ---
>
> Changes since V1:
> - use a single memset as suggested by Bart
>
> drivers/scsi/scsi_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 90f65c8f487a..1d87a809944d 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1166,7 +1166,7 @@ void scsi_init_command(struct scsi_device *dev, struct
> scsi_cmnd *cmd)
>
> /* zero out the cmd, except for the embedded scsi_request */
> memset((char *)cmd + sizeof(cmd->req), 0,
> - sizeof(*cmd) - sizeof(cmd->req));
> + sizeof(*cmd) - sizeof(cmd->req) + dev->host->hostt->cmd_size);
>
> cmd->device = dev;
> cmd->sense_buffer = buf;
Reviewed-by: Bart Van Assche <[email protected]>
