On Thu, Mar 02, 2017 at 02:54:16AM -0800, Kashyap Desai wrote: > Without this fix, driver will enable INTx Interrupt pin even > though MSI-x vectors are enabled. See below lspci output. DisINTx is unset > for MSIx setup. > > lspci -s 85:00.0 -vvv |grep INT |grep Control > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- > Stepping- SERR+ FastB2B- DisINTx- > > After applying this fix, driver will enable INTx Interrupt pin only if Legacy > interrupt method is required. > See below lspci output. DisINTx is unset for MSIx setup. > lspci -s 85:00.0 -vvv |grep INT |grep Control > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- > Stepping- SERR+ FastB2B- DisINTx+ > > Signed-off-by: Kashyap Desai <[email protected]> > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c > b/drivers/scsi/megaraid/megaraid_sas_base.c > index 7ac9a9e..82a8ec8 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > @@ -4990,6 +4990,7 @@ int megasas_set_crash_dump_params(struct > megasas_instance *instance, > struct pci_dev *pdev; > > pdev = instance->pdev; > + pci_intx(pdev, 1);
Please use pci_alloc_irq_vectors with the PCI_IRQ_LEGACY flag here, I'd like to phase out the pci_intx API.
