On 03/18/2017 01:02 AM, Bart Van Assche wrote: > Callers must provide a valid port group to alua_rtpg_queue(). > Issue a kernel warning if that is not the case. > > Signed-off-by: Bart Van Assche <[email protected]> > Cc: Hannes Reinecke <[email protected]> > Cc: Tang Junhui <[email protected]> > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c > b/drivers/scsi/device_handler/scsi_dh_alua.c > index b6849d3ecefe..c01b47e5b55a 100644 > --- a/drivers/scsi/device_handler/scsi_dh_alua.c > +++ b/drivers/scsi/device_handler/scsi_dh_alua.c > @@ -876,7 +876,7 @@ static bool alua_rtpg_queue(struct alua_port_group *pg, > unsigned long flags; > struct workqueue_struct *alua_wq = kaluad_wq; > > - if (!pg || scsi_device_get(sdev)) > + if (WARN_ON_ONCE(!pg) || scsi_device_get(sdev)) > return false; > > spin_lock_irqsave(&pg->lock, flags); > Reviewed-by: Hannes Reinecke <[email protected]>
Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage [email protected] +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
