Hi all, this is a resend of a small patchset for cleaning up SCSI EH. Primary goal is to make asynchronous aborts mandatory; there hasn't been a single report so far where asynchronous abort won't work, so the 'no_async_abort' flag has never been used and will be removed with this patchset. Additionally there's a cleanup to detect retries of failed commands and to inline commands aborts. I've also included the patch to correctly reset the media access timeout counter to avoid it being triggered inadvertedly by several commands timing out for the same device.
As usual, comments and reviews are welcome. Changes to v1: - Include reviews from Christoph Changes to v2: - Include reviews from Bart - Add medium access timeout patch Changes to v3: - Add patch to inline command abort as per suggestion from Christoph - Drop patch to not escalate failed EH commands Changes to v4: - Split off sdrv->eh_action into two functions Christoph Hellwig (1): libsas: allow async aborts Hannes Reinecke (7): scsi_error: count medium access timeout only once per EH run sd: Return SUCCESS in sd_eh_action() after device offline scsi: always send command aborts scsi: make eh_eflags persistent scsi: make scsi_eh_scmd_add() always succeed scsi: make asynchronous aborts mandatory scsi: inline command aborts Documentation/scsi/scsi_eh.txt | 30 ++--- drivers/scsi/libsas/sas_scsi_host.c | 5 - drivers/scsi/scsi.c | 2 - drivers/scsi/scsi_error.c | 218 ++++++++++++------------------------ drivers/scsi/scsi_lib.c | 6 +- drivers/scsi/scsi_priv.h | 4 +- drivers/scsi/sd.c | 29 ++++- drivers/scsi/sd.h | 1 + include/scsi/scsi_driver.h | 1 + include/scsi/scsi_eh.h | 1 + include/scsi/scsi_host.h | 5 - 11 files changed, 115 insertions(+), 187 deletions(-) -- 1.8.5.6
