Hi Dick,

If you don't mind me being pedantic, I've noticed a couple of things.

First, is your different email addresses in from/signed-off-by lines:

On 04/04/2017 02:16 PM, Dick Kennedy wrote:
From: Dick Kennedy <rkenn...@lvnvda1400.lvn.broadcom.net>
[...]
Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>

Second, is there are several indentation/line-break changes in this
'fix' patch too, of which at least one seems inconsistent in the code
(see below) -- that would be better split off to another patch IMHO.

Maybe that would be covered in the scrubbing process you mentioned in
the other/regression thread.


@@ -10312,6 +10315,7 @@ lpfc_pci_probe_one_s3(struct pci_dev *pdev, const 
struct pci_device_id *pid)
        }

        /* Initialize and populate the iocb list per host */
+
        error = lpfc_init_iocb_list(phba, LPFC_IOCB_LIST_CNT);
        if (error) {
                lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
@@ -11092,7 +11096,6 @@ lpfc_pci_probe_one_s4(struct pci_dev *pdev, const 
struct pci_device_id *pid)
        }

        /* Initialize and populate the iocb list per host */
-
        lpfc_printf_log(phba, KERN_INFO, LOG_INIT,
                        "2821 initialize iocb list %d.\n",
                        phba->cfg_iocb_cnt*1024);


cheers,


--
Mauricio Faria de Oliveira
IBM Linux Technology Center

Reply via email to