On Tue, 2017-04-18 at 14:58 +0300, Israel Rukshin wrote: > I tested those patches and I got a NULL dereference at sd_sync_cache_done(). > The test is unloading ib_srp while one port is down. > The previous version worked fine. > > From the log: > [ 190.272412] BUG: unable to handle kernel NULL pointer dereference at > 00000000000002f0 > [ 190.281102] IP: sd_sync_cache_done+0x1b/0x80 [sd_mod]
Hello Israel, Thanks for testing. I assume that this data refers to the sd_printk() statement? That statement was executed properly in my tests. Anyway, I will leave out that statement, retest and repost this patch series. There is a del_gendisk() call in sd just before the sd_shutdown() call so that means it's not safe to access the disk pointer from anywhere in sd_shutdown(). Bart.
