On Fri, Aug 04, 2017 at 05:47:19PM -0700, James Smart wrote:
> +     /* For nvme, swap the nrport. */
> +     keep_nrport = new_ndlp->nrport;
> +     new_ndlp->nrport = ndlp->nrport;
> +

The above comment did trigger a "Please use the swap() macro" warning in my
brain, which isn't applicable here. Can we maybe reprase it to something like:

/* For NVMe, cache new_ndlp->nrport and override with ndlp->nrport */

Otherwise,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumsh...@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Reply via email to