On 08/10/2017 12:08 AM, Don Brace wrote:
>> -----Original Message-----
>> From: Hannes Reinecke [mailto:h...@suse.de]
>> Sent: Tuesday, August 08, 2017 3:35 AM
>> To: Martin K. Petersen <martin.peter...@oracle.com>
>> Cc: Don Brace <don.br...@microsemi.com>; Christoph Hellwig
>> <h...@lst.de>; James Bottomley
>> <james.bottom...@hansenpartnership.com>; Meelis Roos
>> <mr...@linux.ee>; email@example.com; Hannes Reinecke
>> Subject: [PATCH RESEND 0/6] hpsa: support legacy boards
>> EXTERNAL EMAIL
>> (Resend to include linux-scsi)
>> Hi all,
>> this patch adds support for legacy boards, ie for boards previously
>> supported by cciss only.
>> With this patchset the hpsa driver should work with all Smart Array
>> boards if the 'hpsa_allow_any' module option is set, rendering the
>> cciss driver obsolete.
>> Hannes Reinecke (5):
>> hpsa: consolidate status variables
>> hpsa: add support for legacy boards
>> hpsa: disable volume status check for older controller
>> hpsa: Ignore errors for unsupported LV_DEVICE_ID VPD page
>> hpsa: do not print errors for unsupported report luns format
>> Jeff Mahoney (1):
>> hpsa: handle unsupported devices more gracefully
>> drivers/scsi/hpsa.c | 131
>> drivers/scsi/hpsa.h | 57 ++++++++++++++++++++---
>> 2 files changed, 162 insertions(+), 26 deletions(-)
> NACK this series
> We do not want to support these older controllers in the hpsa driver.
> While the driver may load and manage requests under healthy conditions
> many features will not be supported. Customers will not have support
> for any issues involving these controllers.
> We would need to track these changes in our OOB driver adding
> more confusion.
Weelll ... that is _precisely_ why I introduced the 'unsupported' flag
to the hba structure; once this is set we have encountered an
unsupported board, and things might not work as expected.
More importantly, you don't have to support that board.
We can even add a stronger wording if you like, eg printing out a big
fat warning in dmesg
'This board is unsupported, some features might not work'.
So where's the bother here?
Dr. Hannes Reinecke Teamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)